Skip to content

Add op(upsample linear1d) | feat(torchlib) #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 18, 2024

Conversation

xiaowuhu
Copy link
Contributor

@xiaowuhu xiaowuhu commented Jan 2, 2024

No description provided.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a85d3f) 78.82% compared to head (4de365c) 78.88%.

❗ Current head 4de365c differs from pull request most recent head 3cf37cb. Consider uploading reports for the commit 3cf37cb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1245      +/-   ##
==========================================
+ Coverage   78.82%   78.88%   +0.05%     
==========================================
  Files         119      119              
  Lines       15668    15697      +29     
  Branches     2476     2481       +5     
==========================================
+ Hits        12350    12382      +32     
+ Misses       2910     2906       -4     
- Partials      408      409       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 2, 2024

Test Results

     24 files  ± 0      24 suites  ±0   1h 32m 29s ⏱️ + 2m 27s
 11 387 tests + 4   8 440 ✅ + 4    2 944 💤  - 1    3 ❌ +1 
257 669 runs  +59  58 539 ✅ +57  199 008 💤 ±0  122 ❌ +2 

For more details on these failures, see this check.

Results for commit f7d4a1e. ± Comparison against base commit 1231cc0.

This pull request removes 21 and adds 25 tests. Note that renamed tests count towards both.
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_328_aten_upsample_nearest2d
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_329_aten_ones_like
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_330_aten_roll
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_331_aten_roll_complex
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_332_aten_scatter_reduce
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_333_aten_slice_scatter
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_334_aten_slice
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_335_aten_stft
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_336_aten_sum_dim_IntList
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_337_aten_tensor_bool
…
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function__aten_upsample_linear1d_onnx
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_328_aten_upsample_linear1d
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_329_aten_upsample_nearest2d
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_330_aten_ones_like
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_331_aten_roll
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_332_aten_roll_complex
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_333_aten_scatter_reduce
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_334_aten_slice_scatter
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_335_aten_slice
onnxscript.tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_336_aten_stft
…

♻️ This comment has been updated with latest results.

@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Jan 3, 2024
@justinchuby justinchuby changed the title add op(upsample linear1d) | feat(torchlib) Add op(upsample linear1d) | feat(torchlib) Jan 18, 2024
@justinchuby justinchuby added the merge at lgtm Reviewers can merge when they approve label Jan 18, 2024
@justinchuby justinchuby merged commit 8785231 into main Jan 18, 2024
@justinchuby justinchuby deleted the xiaowu/AddOp(upsample_linear1d) branch January 18, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge at lgtm Reviewers can merge when they approve module: torchlib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

2 participants