Skip to content

Minor cleanup #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions onnxscript/rewriter/ort_fusions/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,5 @@
"ORT_PATTERN_REWRITE_RULES",
]

from onnxscript.rewriter.ort_fusions import (
fused_matmul_rule_sets,
# group_normalization_merge_silu,
instance_to_group_normalization,
softmax,
)
from onnxscript.rewriter.ort_fusions._core import optimize_for_ort

ORT_PATTERN_REWRITE_RULES = [
*softmax.rules.rules,
*instance_to_group_normalization.rules.rules,
# NOTE: group normalization merge silu should be applied after instance to group normalization
# *group_normalization_merge_silu.rules.rules,
*fused_matmul_rule_sets.fused_matmul_rule_sets(),
]
from onnxscript.rewriter.ort_fusions._core import ORT_PATTERN_REWRITE_RULES, optimize_for_ort
17 changes: 16 additions & 1 deletion onnxscript/rewriter/ort_fusions/_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,28 @@

import onnxscript.ir as ir
from onnxscript.optimizer import optimize, remove_unused_nodes
from onnxscript.rewriter import rewrite
from onnxscript.rewriter.ort_fusions import (
fused_matmul_rule_sets,
# group_normalization_merge_silu,
instance_to_group_normalization,
softmax,
)
from onnxscript.rewriter.ort_fusions.cos_sin_cache import fuse_cos_sin_cache
from onnxscript.rewriter.ort_fusions.mha import fuse_mha
from onnxscript.rewriter.ort_fusions.rms_normalization import fuse_rms_normalization
from onnxscript.rewriter.ort_fusions.rotary_embedding import fuse_rotary_embedding
from onnxscript.rewriter.ort_fusions.sdpa import fuse_sdpa
from onnxscript.rewriter.ort_fusions.skip_normalization import fuse_normalization

ORT_PATTERN_REWRITE_RULES = [
*softmax.rules.rules,
*instance_to_group_normalization.rules.rules,
# NOTE: group normalization merge silu should be applied after instance to group normalization
# *group_normalization_merge_silu.rules.rules,
*fused_matmul_rule_sets.fused_matmul_rule_sets(),
]


def fuse_xformers(model: ir.Model) -> None:
optimize(model)
Expand All @@ -24,5 +39,5 @@


def optimize_for_ort(model: ir.Model) -> None:
# TODO(rama): Include the other optimizations
rewrite(model, ORT_PATTERN_REWRITE_RULES)

Check warning on line 42 in onnxscript/rewriter/ort_fusions/_core.py

View check run for this annotation

Codecov / codecov/patch

onnxscript/rewriter/ort_fusions/_core.py#L42

Added line #L42 was not covered by tests
fuse_xformers(model)
Loading