Fix include_self for scatter_reduce #2090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2090 +/- ##
==========================================
+ Coverage 72.93% 72.99% +0.05%
==========================================
Files 223 223
Lines 29484 29514 +30
Branches 3483 3492 +9
==========================================
+ Hits 21504 21543 +39
+ Misses 6813 6802 -11
- Partials 1167 1169 +2 ☔ View full report in Codecov by Sentry. |
justinchuby
reviewed
Mar 7, 2025
justinchuby
reviewed
Mar 7, 2025
justinchuby
reviewed
Mar 7, 2025
justinchuby
reviewed
Mar 7, 2025
justinchuby
reviewed
Mar 7, 2025
justinchuby
reviewed
Mar 7, 2025
justinchuby
reviewed
Mar 7, 2025
Co-authored-by: Justin Chu <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
justinchuby
reviewed
Mar 10, 2025
justinchuby
approved these changes
Mar 14, 2025
justinchuby
added
the
module: torchlib
Co-authored-by: Justin Chu <[email protected]>
|
I will take a look at the tests |
justinchuby
reviewed
Mar 25, 2025
justinchuby
reviewed
Mar 25, 2025
justinchuby
reviewed
Mar 26, 2025
justinchuby
reviewed
Mar 26, 2025
justinchuby
reviewed
Mar 26, 2025
bmehta001
pushed a commit
to bmehta001/onnxscript
that referenced
this pull request
Apr 11, 2025
Implement logic for include_self. Fixes pytorch/pytorch#147617 --------- Co-authored-by: Justin Chu <[email protected]> Co-authored-by: Ti-Tai Wang <[email protected]>
bmehta001
pushed a commit
to bmehta001/onnxscript
that referenced
this pull request
Apr 11, 2025
Implement logic for include_self. Fixes pytorch/pytorch#147617 --------- Co-authored-by: Justin Chu <[email protected]> Co-authored-by: Ti-Tai Wang <[email protected]>
bmehta001
pushed a commit
to bmehta001/onnxscript
that referenced
this pull request
Apr 11, 2025
Implement logic for include_self. Fixes pytorch/pytorch#147617 --------- Co-authored-by: Justin Chu <[email protected]> Co-authored-by: Ti-Tai Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement logic for include_self. Fixes pytorch/pytorch#147617