-
Notifications
You must be signed in to change notification settings - Fork 72
A couple of extensions to MHA fusion #2106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 21 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
justinchuby
reviewed
Mar 13, 2025
justinchuby
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of extensions to MHA fusion:
One deals with variations in positions-ids. The challenge is to verify that the position-ids used in the two RotaryEmbedding are the same. In some models, they are the same value (by reference). In some models, there is some duplication of the code in computing the 2D position-id from 1D position-id. If we had a common-sub-expression identification/elimination, that would help. For now, just handling it in the pattern itself.
The second deals with variations in how the last two axes of key are transposed. Some models reshape the input tensor to 3D and do the transpose, while some directly transpose a 4D tensor.