Skip to content

Make test test_smollm 20% faster #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 16, 2025
Merged

Make test test_smollm 20% faster #2107

merged 8 commits into from
Mar 16, 2025

Conversation

xadupre
Copy link
Member

@xadupre xadupre commented Mar 14, 2025

No description provided.

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.96%. Comparing base (489e6b7) to head (f1d3ff3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2107      +/-   ##
==========================================
- Coverage   72.97%   72.96%   -0.01%     
==========================================
  Files         216      216              
  Lines       28913    28910       -3     
  Branches     3422     3422              
==========================================
- Hits        21100    21095       -5     
- Misses       6660     6663       +3     
+ Partials     1153     1152       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby
Copy link
Collaborator

Thanks! For my understanding, is it ort optimization that's taking time

@xadupre
Copy link
Member Author

xadupre commented Mar 14, 2025

From the profiling from the slowest test, the time spent in optimization is small, it is all about serialization and onnxruntime optimization.

Copy link
Collaborator

@gramalingam gramalingam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@justinchuby justinchuby merged commit 5bc7de5 into microsoft:main Mar 16, 2025
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants