Skip to content

Fix Op (convolution) | add nd support to convolution #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

titaiwangms
Copy link
Contributor

Screenshot 2025-03-14 171007

Ran into a case that aten.convolution.default takes 2D image with [0] as padding, which broke our assumption of it comes with the same rank of nd image.

@titaiwangms titaiwangms added the module: torchlib Related to the torch/aten function lib in development label Mar 15, 2025
@titaiwangms titaiwangms requested a review from justinchuby March 15, 2025 00:11
Copy link

codecov bot commented Mar 15, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.97%. Comparing base (5bc7de5) to head (8371724).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
onnxscript/function_libs/torch_lib/ops/core.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2108   +/-   ##
=======================================
  Coverage   72.96%   72.97%           
=======================================
  Files         216      216           
  Lines       28910    28918    +8     
  Branches     3422     3425    +3     
=======================================
+ Hits        21095    21103    +8     
  Misses       6663     6663           
  Partials     1152     1152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titaiwangms titaiwangms enabled auto-merge (squash) March 17, 2025 16:10
@justinchuby justinchuby disabled auto-merge March 17, 2025 16:25
@titaiwangms titaiwangms merged commit 6be9d18 into microsoft:main Mar 17, 2025
24 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

2 participants