Add Op (aten::masked_scatter) | feat (torchlib) #2112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titaiwangms
added
the
module: torchlib
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2112 +/- ##
==========================================
+ Coverage 72.97% 72.98% +0.01%
==========================================
Files 216 216
Lines 28918 28928 +10
Branches 3425 3426 +1
==========================================
+ Hits 21103 21114 +11
+ Misses 6663 6662 -1
Partials 1152 1152 ☔ View full report in Codecov by Sentry. |
justinchuby
reviewed
Mar 18, 2025
justinchuby
reviewed
Mar 18, 2025
justinchuby
approved these changes
Mar 18, 2025
xadupre
reviewed
Mar 18, 2025
| ends = op.Gather(op.Shape(index), op.Constant(value_ints=[0]), axis=0) | ||
| source = op.Slice(source, starts, ends, axes) | ||
|
|
||
| return op.ScatterND(self, index, source) |
There was a problem hiding this comment.
What about self * (1-mask) + mask * source or mask * (source - self) + self ?
There was a problem hiding this comment.
The implementation is following torchscript converter. If we find it's too slow, we can change it later. I am unblocking Gemma3 for now.
There was a problem hiding this comment.
Maybe create a follow up issue for tracking?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Gemma3, the error lacks of support is raised.
https://github.com/huggingface/transformers/blob/7f5077e53682ca855afc826162b204ebf809f1f9/src/transformers/models/gemma3/modeling_gemma3.py#L1339