-
Notifications
You must be signed in to change notification settings - Fork 72
[Pass] Remove metadata_props and doc_string from the model #2182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
titaiwangms
merged 14 commits into
microsoft:main
from
titaiwangms:titaiwang/pass_to_remove_metadata
Apr 14, 2025
Merged
[Pass] Remove metadata_props and doc_string from the model #2182
titaiwangms
merged 14 commits into
microsoft:main
from
titaiwangms:titaiwang/pass_to_remove_metadata
Apr 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 2 Tests Failed:
View the top 1 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
justinchuby
reviewed
Apr 11, 2025
justinchuby
reviewed
Apr 11, 2025
justinchuby
reviewed
Apr 11, 2025
justinchuby
reviewed
Apr 11, 2025
justinchuby
reviewed
Apr 11, 2025
justinchuby
reviewed
Apr 11, 2025
justinchuby
reviewed
Apr 11, 2025
justinchuby
reviewed
Apr 12, 2025
justinchuby
reviewed
Apr 12, 2025
justinchuby
reviewed
Apr 12, 2025
justinchuby
reviewed
Apr 12, 2025
justinchuby
reviewed
Apr 12, 2025
justinchuby
reviewed
Apr 14, 2025
justinchuby
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline. Changes to the metadata_props in ir.Function lgtm. Thanks!
justinchuby
reviewed
Apr 14, 2025
justinchuby
reviewed
Apr 14, 2025
Co-authored-by: Justin Chu <[email protected]>
justinchuby
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2163