-
Notifications
You must be signed in to change notification settings - Fork 72
Updated docs for rewrite-patterns #2196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated docs for rewrite-patterns #2196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2196 +/- ##
==========================================
- Coverage 74.26% 74.24% -0.03%
==========================================
Files 224 224
Lines 29392 29398 +6
Branches 3416 3418 +2
==========================================
- Hits 21829 21827 -2
- Misses 6412 6419 +7
- Partials 1151 1152 +1 ☔ View full report in Codecov by Sentry. |
Could you remove the trailing whitespaces? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Description
Added a note to the rewrite patterns tutorial clarifying that the order of rules in
pattern_rewrite_rules
matters. Some rules depend on others being applied first, so incorrect order may lead to unexpected results.@justinchuby let me know, does this helps Or something else is needed?
Fixes #2169