Skip to content

Updated docs for rewrite-patterns #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LuniaKunal
Copy link
Contributor

Description
Added a note to the rewrite patterns tutorial clarifying that the order of rules in pattern_rewrite_rules matters. Some rules depend on others being applied first, so incorrect order may lead to unexpected results.

@justinchuby let me know, does this helps Or something else is needed?

Fixes #2169

Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.24%. Comparing base (8f96dc9) to head (109d608).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2196      +/-   ##
==========================================
- Coverage   74.26%   74.24%   -0.03%     
==========================================
  Files         224      224              
  Lines       29392    29398       +6     
  Branches     3416     3418       +2     
==========================================
- Hits        21829    21827       -2     
- Misses       6412     6419       +7     
- Partials     1151     1152       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby
Copy link
Collaborator

Could you remove the trailing whitespaces?

@justinchuby justinchuby requested a review from Copilot April 14, 2025 15:06
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@justinchuby justinchuby enabled auto-merge (squash) April 14, 2025 16:15
@justinchuby justinchuby disabled auto-merge April 14, 2025 16:15
@justinchuby justinchuby enabled auto-merge (squash) April 14, 2025 16:15
@justinchuby justinchuby merged commit e404922 into microsoft:main Apr 14, 2025
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[docs] RewriteRuleSet's order dependency should be documented
3 participants