-
Notifications
You must be signed in to change notification settings - Fork 72
Update proto comparison error message #2215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 16 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
a: google.protobuf.message.Message | Any, b: google.protobuf.message.Message | Any | ||
actual: google.protobuf.message.Message | Any, | ||
expected: google.protobuf.message.Message | Any, | ||
ignore_initializer_value_proto: bool = False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ignore-initializer-value-proto seems a very specialized niche-case ... why/where exactly do you need it? Wonder if there is some more general-purpose mechanism to achieve that ... I don't have any suggestions at the moment though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are models in the onnx model zoo that does not have value info proto for initializers, but roundtripping will add those protos to the model. So I created a flag to ignore them. It is used in tools/ir/model_zoo_test/model_zoo_test.py
Update proto comparison error message to display all differences between two protos instead of failing at the first difference.