Skip to content

Create short tensor str for nodes #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2025

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented May 1, 2025

The display of constant value is now more concise.

>>> from onnxscript import ir
>>> n = ir.node("Add", [ir.Value(name="a", const_value=ir.tensor(1)), ir.Value(name="b", const_value=ir.tensor([1]*10))], name="n0")
>>> print(n)
%"anonymous:123273301338960"<?,?> ⬅️ ::Add(%"a"{1}, %"b"{[1, 1, 1, 1, 1, 1, 1, 1, 1, 1]})
>>> print(repr(n))
Node(name='n0', domain='', op_type='Add', inputs=(Value(name='a', const_value={Tensor<INT64,[]>(array(1), name=None)}), Value(name='b', const_value={Tensor<INT64,[10]>(array([1, 1, 1, 1, 1, 1, 1, 1, 1, 1]), name=None)})), attributes=OrderedDict(), overload='', outputs=(Value(name='anonymous:135329937264592', producer='n0', index=0),), version=None, doc_string=None)

@justinchuby justinchuby requested review from gramalingam and Copilot May 1, 2025 18:27
@justinchuby justinchuby added topic: ux User experience related topics module: IR Intermediate representation labels May 1, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve the display of constant tensor values in nodes by producing a more concise string representation.

  • Introduces a helper function (_short_tensor_str_for_node) to format the constant tensor value.
  • Updates Node’s str method to utilize the new helper function for displaying constant values.

Copy link

codecov bot commented May 1, 2025

❌ 9 Tests Failed:

Tests completed Failed Passed Skipped
15377 9 15368 2338
View the top 3 failed test(s) by shortest run time
onnxscript.backend.onnx_export_test.TestOnnxBackEnd::test_export2python_produces_correct_onnx_script_model_0009_test_add
Stack Traces | 0.003s run time
onnxscript\backend\onnx_export_test.py:137: in extract_functions
    mod = importlib.import_module(import_name)
C:\hostedtoolcache\windows\Python\3.11.9\x64\Lib\importlib\__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
E   ModuleNotFoundError: No module named 'tests.onnx_backend_test_code.test_add'

The above exception was the direct cause of the following exception:
.nox\test_onnx_weekly\Lib\site-packages\parameterized\parameterized.py:620: in standalone_func
    return func(*(a + p.args), **p.kwargs, **kw)
onnxscript\backend\onnx_export_test.py:271: in test_export2python_produces_correct_onnx_script_model
    functions = extract_functions(backend_test.name, code, self.test_folder)
onnxscript\backend\onnx_export_test.py:139: in extract_functions
    raise AssertionError(
E   AssertionError: Unable to import 'tests.onnx_backend_test_code.test_add' (e=No module named 'tests.onnx_backend_test_code.test_add') (file: 'D:\\a\\onnxscript\\onnxscript\\tests\\onnx_backend_test_code\\test_add.py', absolute path: 'D:\\a\\onnxscript\\onnxscript\\tests\\onnx_backend_test_code\\test_add.py', current folder: D:\a\onnxscript\onnxscript
E   ---- CONTENT --
E   import numpy
E   from onnx import TensorProto
E   from onnx.helper import make_tensor
E   from onnxscript import script, external_tensor
E   from onnxscript.values import Opset
E   from onnxscript.onnx_types import FLOAT
E   from onnxscript.onnx_opset import opset14
E   
E   @script()
E   def bck_test_add(x: FLOAT[3,4,5], y: FLOAT[3,4,5]) -> (FLOAT[3,4,5]):
E       sum = opset14.Add(x, y)
E       return sum
onnxscript.backend.onnx_export_test.TestOnnxBackEnd::test_export2python_produces_correct_onnx_script_model_0740_test_max_two_inputs
Stack Traces | 0.004s run time
onnxscript\backend\onnx_export_test.py:137: in extract_functions
    mod = importlib.import_module(import_name)
C:\hostedtoolcache\windows\Python\3.11.9\x64\Lib\importlib\__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
E   ModuleNotFoundError: No module named 'tests.onnx_backend_test_code.test_max_two_inputs'

The above exception was the direct cause of the following exception:
.nox\test_onnx_weekly\Lib\site-packages\parameterized\parameterized.py:620: in standalone_func
    return func(*(a + p.args), **p.kwargs, **kw)
onnxscript\backend\onnx_export_test.py:271: in test_export2python_produces_correct_onnx_script_model
    functions = extract_functions(backend_test.name, code, self.test_folder)
onnxscript\backend\onnx_export_test.py:139: in extract_functions
    raise AssertionError(
E   AssertionError: Unable to import 'tests.onnx_backend_test_code.test_max_two_inputs' (e=No module named 'tests.onnx_backend_test_code.test_max_two_inputs') (file: 'D:\\a\\onnxscript\\onnxscript\\tests\\onnx_backend_test_code\\test_max_two_inputs.py', absolute path: 'D:\\a\\onnxscript\\onnxscript\\tests\\onnx_backend_test_code\\test_max_two_inputs.py', current folder: D:\a\onnxscript\onnxscript
E   ---- CONTENT --
E   import numpy
E   from onnx import TensorProto
E   from onnx.helper import make_tensor
E   from onnxscript import script, external_tensor
E   from onnxscript.values import Opset
E   from onnxscript.onnx_types import FLOAT
E   from onnxscript.onnx_opset import opset13
E   
E   @script()
E   def bck_test_max_two_inputs(data_0: FLOAT[3], data_1: FLOAT[3]) -> (FLOAT[3]):
E       result = opset13.Max(data_0, data_1)
E       return result
onnxscript.backend.onnx_export_test.TestOnnxBackEnd::test_export2python_produces_correct_onnx_script_model_1388_test_top_k_negative_axis
Stack Traces | 0.004s run time
onnxscript\backend\onnx_export_test.py:137: in extract_functions
    mod = importlib.import_module(import_name)
C:\hostedtoolcache\windows\Python\3.11.9\x64\Lib\importlib\__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
E   ModuleNotFoundError: No module named 'tests.onnx_backend_test_code.test_top_k_negative_axis'

The above exception was the direct cause of the following exception:
.nox\test_onnx_weekly\Lib\site-packages\parameterized\parameterized.py:620: in standalone_func
    return func(*(a + p.args), **p.kwargs, **kw)
onnxscript\backend\onnx_export_test.py:271: in test_export2python_produces_correct_onnx_script_model
    functions = extract_functions(backend_test.name, code, self.test_folder)
onnxscript\backend\onnx_export_test.py:139: in extract_functions
    raise AssertionError(
E   AssertionError: Unable to import 'tests.onnx_backend_test_code.test_top_k_negative_axis' (e=No module named 'tests.onnx_backend_test_code.test_top_k_negative_axis') (file: 'D:\\a\\onnxscript\\onnxscript\\tests\\onnx_backend_test_code\\test_top_k_negative_axis.py', absolute path: 'D:\\a\\onnxscript\\onnxscript\\tests\\onnx_backend_test_code\\test_top_k_negative_axis.py', current folder: D:\a\onnxscript\onnxscript
E   ---- CONTENT --
E   import numpy
E   from onnx import TensorProto
E   from onnx.helper import make_tensor
E   from onnxscript import script, external_tensor
E   from onnxscript.values import Opset
E   from onnxscript.onnx_types import FLOAT, INT64
E   from onnxscript.onnx_opset import opset11
E   
E   @script()
E   def bck_test_top_k_negative_axis(x: FLOAT[3,4], k: INT64[1]) -> (FLOAT[3,3], INT64[3,3]):
E       values, indices = opset11.TopK(x, k, axis=-1)
E       return values, indices

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@justinchuby
Copy link
Collaborator Author

@gramalingam

@justinchuby justinchuby enabled auto-merge (squash) May 1, 2025 19:14
@justinchuby justinchuby merged commit 2766661 into main May 2, 2025
25 of 29 checks passed
@justinchuby justinchuby deleted the justinchu/short_tensor_str_for_node branch May 2, 2025 16:20
@github-project-automation github-project-automation bot moved this from Todo to Done in ONNX Script Review Board May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: IR Intermediate representation topic: ux User experience related topics
Projects
Development

Successfully merging this pull request may close these issues.

2 participants