Remove unnecessary warning #2327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2327 +/- ##
==========================================
- Coverage 73.73% 73.71% -0.02%
==========================================
Files 239 239
Lines 30933 30929 -4
Branches 3505 3505
==========================================
- Hits 22807 22798 -9
- Misses 6913 6916 +3
- Partials 1213 1215 +2 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
May 22, 2025
bmehta001
pushed a commit
to bmehta001/onnxscript
that referenced
this pull request
May 22, 2025
param_schemas is still used in many places in the code. The warning should be added only the package itself does not use it anymore. Looking at the code, the replacement is not really obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
param_schemas is still used in many places in the code. The warning should be added only the package itself does not use it anymore. Looking at the code, the replacement is not really obvious.