docs: cleanup documentation for function-based rewrites📄 #2359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinchuby
added
the
topic: documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2359 +/- ##
=======================================
Coverage 70.22% 70.22%
=======================================
Files 197 197
Lines 24742 24742
Branches 2650 2650
=======================================
Hits 17375 17375
Misses 6451 6451
Partials 916 916 ☔ View full report in Codecov by Sentry. |
justinchuby
reviewed
Jun 3, 2025
justinchuby
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With https://github.com/microsoft/onnxscript/pull/2039/files support for
function-basedrewriting was dropped. Some tutorials and the the readme were still referencing function-based rewrites.@justinchuby / @gramalingam Could you please review? Any feedback is appreciated.