Skip to content

Add missing converter for _local_scalar_dense #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 11, 2025

Conversation

xadupre
Copy link
Member

@xadupre xadupre commented Jun 6, 2025

No description provided.

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.15%. Comparing base (5293005) to head (7ef1912).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2367      +/-   ##
==========================================
+ Coverage   70.14%   70.15%   +0.01%     
==========================================
  Files         197      197              
  Lines       24964    24966       +2     
  Branches     2667     2669       +2     
==========================================
+ Hits        17512    17516       +4     
+ Misses       6524     6522       -2     
  Partials      928      928              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-project-automation github-project-automation bot moved this from Todo to Done in ONNX Script Review Board Jun 6, 2025
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Jun 6, 2025
@justinchuby justinchuby enabled auto-merge (squash) June 6, 2025 15:16
@justinchuby
Copy link
Collaborator

justinchuby commented Jun 6, 2025

Actually: you want to duplicate the opinfo entry and use it like so:

TorchLibOpInfo(
"ops.aten._local_scalar_dense",
core_ops.aten__local_scalar_dense,
),

add:

 TorchLibOpInfo( 
     "ops.aten._local_scalar_dense.bool",  # This should match the opinfo name
     core_ops.aten__local_scalar_dense_bool, 
 ), 

@justinchuby
Copy link
Collaborator

I think we can actually merge the functions. Making an attempt

@justinchuby justinchuby merged commit dcf98c8 into microsoft:main Jun 11, 2025
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

3 participants