Skip to content

[torchlib] Unregister aten::max.other #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

titaiwangms
Copy link
Contributor

Issue revealed by #2371, which aten.max.other is lack of matching overload. It's caused by missing type promotion. The reason is that aten::max.other (binary max) is an alias of aten::maimum.default. Thus, iwhen type promotion pass dispatches torch.max through __torch__dispatch__, it does not find aten::max.other (However, I am not sure how make_fx dispatches torch.max to aten::max.other).

The existence of aten::max.other looks like a legacy code: pytorch/pytorch#42579.

@titaiwangms titaiwangms added the module: torchlib Related to the torch/aten function lib in development label Jun 12, 2025
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (949bc24) to head (6bb2001).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2377      +/-   ##
==========================================
- Coverage   70.12%   70.12%   -0.01%     
==========================================
  Files         197      197              
  Lines       25003    25003              
  Branches     2670     2670              
==========================================
- Hits        17534    17533       -1     
- Misses       6537     6538       +1     
  Partials      932      932              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titaiwangms titaiwangms enabled auto-merge (squash) June 13, 2025 23:00
@titaiwangms titaiwangms disabled auto-merge June 13, 2025 23:00
@titaiwangms titaiwangms added the merge at lgtm Reviewers can merge when they approve label Jun 13, 2025
@titaiwangms titaiwangms requested a review from justinchuby June 13, 2025 23:00
@titaiwangms titaiwangms enabled auto-merge (squash) June 13, 2025 23:16
@titaiwangms titaiwangms merged commit 6e6f521 into microsoft:main Jun 13, 2025
29 of 32 checks passed
@justinchuby justinchuby linked an issue Jun 14, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge at lgtm Reviewers can merge when they approve module: torchlib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

[torchlib] aten.min.other
2 participants