Added padding_idx=None option and new test cases for aten_embedding_bag #2549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2549 +/- ##
==========================================
+ Coverage 70.00% 70.33% +0.33%
==========================================
Files 215 218 +3
Lines 25992 26430 +438
Branches 2606 2647 +41
==========================================
+ Hits 18196 18590 +394
- Misses 6896 6936 +40
- Partials 900 904 +4 ☔ View full report in Codecov by Sentry. |
|
@justinchuby I can handle the linting issues, but I’m confused about the other CI failures — could you help? |
justinchuby
reviewed
Sep 11, 2025
| opinfo_core.OpInfo( | ||
| "test_embedding_bag_with_padding_idx_int", | ||
| op=torch.nn.functional.embedding_bag, | ||
| dtypes=(torch.float32,), |
There was a problem hiding this comment.
I think it’s this line: you need the all_float_types() etc. construct for specifying supported dtypes. See other existing op infos for reference.
There was a problem hiding this comment.
changed it to common_dtype.floating_types_and_half(), similar to other test cases
justinchuby
reviewed
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issues #2219, #2385 and the first part of #2489
This commit adds new test cases and the necessary implementation changes to correctly support the
padding_idx=Noneoption in theaten_embedding_bagoperator. This aligns the ONNX Script operator with PyTorch's native behavior and expands test coverage for this feature.Key Changes:
core.py: Theaten_embedding_bag_padding_idxfunction has been updated to handlepadding_idx=None. This new code routes the operation to the standardaten_embedding_bagimplementation when no padding indices are specified.extra_opinfo.py: Two newOpInfodefinitions,test_embedding_bag_with_padding_idx_noneandtest_embedding_bag_with_padding_idx_int, have been added to theOP_DBlist. These provide input samples to test the new and existingpadding_idxfunctionality.ops_test_data.py: TheTESTED_TORCHLIB_OPStuple has been updated to include the new tests, ensuring they are discovered and executed by the test runner.