Skip to content

feat(atenlib): ops 4/n #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Dec 15, 2022
Merged

feat(atenlib): ops 4/n #256

merged 45 commits into from
Dec 15, 2022

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Dec 14, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Some more math and matrix ops

@justinchuby
fix: annotate script()
55f8dd9 
To allow mypy to analyze typing for annotated functions. Otherwise it complains that "Untyped decorator makes function "ones_like" untyped  [misc]"

[ghstack-poisoned]
@justinchuby
feat(atenlib): clamp, lt, gt
8a3a587 
[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): implement aten functions 1/n"
f821b6a 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like


[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): implement aten functions 1/n"
aecc148 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like


[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): implement aten functions 1/n"
6555a55 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like


[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): implement aten functions 1/n"
f8385b0 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like


[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): implement aten functions 1/n"
468f86f 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like


[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): implement aten functions 1/n"
47b8380 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): implement aten functions 1/n"
00f1760 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): implement aten functions 1/n"
060f9db 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): implement aten functions 1/n"
497cb16 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): implement aten functions 1/n"
9bb4038 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): implement aten functions 1/n"
d24110a 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): implement aten functions 1/n"
cbfb867 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): implement aten functions 1/n"
875f235 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): implement aten functions 1/n"
27008e1 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): implement aten functions 1/n"
3a8737d 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): implement aten functions 1/n"
c5871c8 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): implement aten functions 1/n"
012905c 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): implement aten functions 1/n"
49be5ec 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): implement aten functions 1/n"
3a9c5f6 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): implement aten functions 1/n"
d4f09e8 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): implement aten functions 1/n"
ee3143e 
Implemented ops

- lt
- gt
- round
- clamp_min
- clamp_max
- clamp
- repeat
- ones_like

Test:
- Create the ability to skip particular sub tests
- Create a helper function to transform torch inputs into numpy for onnxscript to run on

[ghstack-poisoned]
@justinchuby
feat(atenlib): ops 2/n
691772b 
[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): ops 2/n"
f160dfa 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): ops 2/n"
c8e4a54 
[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): ops 2/n"
7cd967d 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): ops 2/n"
e8f07c9 
[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): ops 2/n"
c4c80a1 
[ghstack-poisoned]
@justinchuby
Update base for Update on "feat(atenlib): ops 2/n"
7c0e305 
[ghstack-poisoned]
@justinchuby justinchuby mentioned this pull request Dec 14, 2022
Merged
justinchuby added a commit that referenced this pull request Dec 14, 2022
@justinchuby
feat(atenlib): ops 3/n
522e828 
Some more math and matrix ops

ghstack-source-id: 4598176
Pull Request resolved: #256
@justinchuby justinchuby changed the title feat(atenlib): ops 3/n feat(atenlib): ops 4/n Dec 14, 2022
@justinchuby justinchuby added module: torchlib Related to the torch/aten function lib in development change base before merge Remember to change the merge base to main when the PR is ready to merge labels Dec 14, 2022
@justinchuby
Update base for Update on "feat(atenlib): ops 4/n"
fbfe507 
Some more math and matrix ops

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): ops 4/n"
1aa6703 
Some more math and matrix ops

[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Dec 14, 2022
@justinchuby
feat(atenlib): ops 3/n
bb2c4ae 
Some more math and matrix ops

ghstack-source-id: 6ae5ad1
Pull Request resolved: #256
@justinchuby
Update base for Update on "feat(atenlib): ops 4/n"
7b1797c 
Some more math and matrix ops

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): ops 4/n"
543997d 
Some more math and matrix ops

[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Dec 14, 2022
@justinchuby
feat(atenlib): ops 3/n
66f2715 
Some more math and matrix ops

ghstack-source-id: b64f805
Pull Request resolved: #256
@codecov
Copy link

codecov bot commented Dec 14, 2022 •
edited
Loading

Codecov Report

Merging #256 (f796bb0) into main (f7ac851) will increase coverage by 0.17%.
The diff coverage is 96.87%.

@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   71.98%   72.16%   +0.17%     
==========================================
  Files          93       93              
  Lines        8918     8916       -2     
==========================================
+ Hits         6420     6434      +14     
+ Misses       2498     2482      -16
Impacted Files Coverage Δ
...t/function_libs/torch_aten/ops_correctness_test.py 95.93% <ø> (ø)
onnxscript/function_libs/torch_aten/ops/nn.py 51.55% <50.00%> (-0.02%) ⬇️
onnxscript/function_libs/torch_aten/ops/core.py 53.45% <100.00%> (+1.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@justinchuby justinchuby requested a review from fatcat-z December 14, 2022 18:52
@justinchuby
Update base for Update on "feat(atenlib): ops 4/n"
1e65d5b 
Some more math and matrix ops

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): ops 4/n"
78b5161 
Some more math and matrix ops

[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Dec 15, 2022
@justinchuby
feat(atenlib): ops 3/n
d6f9405 
Some more math and matrix ops

ghstack-source-id: b6676ce
Pull Request resolved: #256
justinchuby
justinchuby commented Dec 15, 2022
View reviewed changes
onnxscript/function_libs/torch_aten/ops/core.py
raise NotImplementedError()


def aten_celu(self: TensorType, alpha: float = 1.0) -> TensorType:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to nn.

justinchuby
justinchuby commented Dec 15, 2022
View reviewed changes
onnxscript/function_libs/torch_aten/ops/core.py
@@ -785,14 +779,6 @@ def aten_clamp_min_tensor(self, min_):
return op.Max(self, min_)


def aten_clip(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alias of clamp

@justinchuby
Copy link
Collaborator Author

@fatcat-z ready for review

@justinchuby
Update base for Update on "feat(atenlib): ops 4/n"
9e2f306 
Some more math and matrix ops

[ghstack-poisoned]
@justinchuby
Update on "feat(atenlib): ops 4/n"
d2d0522 
Some more math and matrix ops

[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Dec 15, 2022
@justinchuby
feat(atenlib): ops 3/n
0b4b7a2 
Some more math and matrix ops

ghstack-source-id: cad30d9
Pull Request resolved: #256
fatcat-z
fatcat-z approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

justinchuby added a commit that referenced this pull request Dec 15, 2022
@justinchuby
feat(atenlib): ops 2/n (#252)
b2d3d27 
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #256
* #255
* __->__ #252
justinchuby added a commit that referenced this pull request Dec 15, 2022
@justinchuby
feat(atenlib): ops 3/n (#255)
f7ac851 
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #256
* __->__ #255
* #252

A bunch of matmul and math ops
@justinchuby justinchuby changed the base branch from gh/justinchuby/14/base to main December 15, 2022 06:07
@justinchuby justinchuby merged commit 2512120 into main Dec 15, 2022
@justinchuby justinchuby deleted the gh/justinchuby/14/head branch December 15, 2022 06:15
@justinchuby justinchuby mentioned this pull request Dec 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatcat-z fatcat-z fatcat-z approved these changes

Assignees
No one assigned
Labels
change base before merge Remember to change the merge base to main when the PR is ready to merge module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinchuby @fatcat-z