[Rewriter]: introduce remove_optional_bias#2635
Merged
Merged
Conversation
AyoubMDL
commented
Oct 15, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
|
|
||
| class RemoveOptionalBiasQLinearConvTest(_RemoveOptionalBiasTestBase): | ||
| def _get_test_model(self, zero_bias): |
Check warning
Code scanning / CodeQL
Signature mismatch in overriding method Warning
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2635 +/- ##
==========================================
+ Coverage 70.32% 70.46% +0.13%
==========================================
Files 222 224 +2
Lines 26438 26572 +134
Branches 2632 2637 +5
==========================================
+ Hits 18593 18723 +130
- Misses 6926 6928 +2
- Partials 919 921 +2 ☔ View full report in Codecov by Sentry. |
AyoubMDL
force-pushed
the
remove-optional-bias
branch
from
9735091 to
4547bd2
Compare
gramalingam
reviewed
Oct 17, 2025
gramalingam
approved these changes
Oct 17, 2025
Removes optional bias when it is all zero from Conv, ConvTranspose, Gemm and QLinearConv operations.
AyoubMDL
force-pushed
the
remove-optional-bias
branch
from
4547bd2 to
920a5d3
Compare
justinchuby
approved these changes
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2547. I've kept the same ops as in #2555.