add reshape/view/expand/div/clone/eq/equal #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Codecov Report
@@ Coverage Diff @@
## main #265 +/- ##
==========================================
+ Coverage 73.04% 73.17% +0.12%
==========================================
Files 95 95
Lines 9131 9144 +13
==========================================
+ Hits 6670 6691 +21
+ Misses 2461 2453 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
justinchuby
reviewed
Jan 2, 2023
|
Looking great, thanks! I left a few minor comments |
justinchuby
added
the
module: torchlib
|
I fixed the mypy ignores in #261. No need to add extra type ignores after it is merged |
justinchuby
reviewed
Jan 3, 2023
justinchuby
reviewed
Jan 4, 2023
justinchuby
reviewed
Jan 4, 2023
justinchuby
reviewed
Jan 6, 2023
onnxscript/test/function_libs/torch_aten/ops_correctness_test.py
Outdated
Show resolved
Hide resolved
justinchuby
reviewed
Jan 6, 2023
justinchuby
reviewed
Jan 6, 2023
justinchuby
reviewed
Jan 6, 2023
justinchuby
reviewed
Jan 6, 2023
justinchuby
reviewed
Jan 6, 2023
justinchuby
reviewed
Jan 6, 2023
justinchuby
reviewed
Jan 6, 2023
justinchuby
reviewed
Jan 6, 2023
onnxscript/test/function_libs/torch_aten/ops_correctness_test.py
Outdated
Show resolved
Hide resolved
justinchuby
reviewed
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add reshape, view, expand, div, clone, eq, equal