Skip to content

feat(atenlib): logarithmic ops; test aten::full #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jan 10, 2023
Merged

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Jan 5, 2023

Implement logarithmic ops:

log
log10
log1p
log2
logaddexp
logaddexp2
logcumsumexp
logsumexp
logdet
log_sigmoid
xlogy

  • Also enable test for aten::full and rename kwargs wranglers to input wrangers.
    -Note: logcumsumexp is not numerically stable, but I will leave the fix as a TODO.

Reference: https://github.com/pytorch/pytorch/pull/36308/files

@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Jan 5, 2023
@justinchuby justinchuby mentioned this pull request Jan 5, 2023
@justinchuby justinchuby changed the title feat(atenlib): log ops feat(atenlib): log ops; test aten::full Jan 7, 2023
@justinchuby justinchuby changed the title feat(atenlib): log ops; test aten::full feat(atenlib): logarithmic ops; test aten::full Jan 7, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #281 (5e141bf) into main (109bf7f) will increase coverage by 0.13%.
The diff coverage is 98.57%.

❗ Current head 5e141bf differs from pull request most recent head 1f4ac4e. Consider uploading reports for the commit 1f4ac4e to get more accurate results

@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   72.73%   72.87%   +0.13%     
==========================================
  Files          95       97       +2     
  Lines        9176     9330     +154     
==========================================
+ Hits         6674     6799     +125     
- Misses       2502     2531      +29     
Impacted Files Coverage Δ
onnxscript/function_libs/torch_aten/ops/core.py 61.89% <96.77%> (+1.08%) ⬆️
onnxscript/function_libs/torch_aten/ops/nn.py 56.94% <100.00%> (+0.48%) ⬆️
onnxscript/function_libs/torch_aten/ops/special.py 55.64% <100.00%> (ø)
onnxscript/onnx_opset/__init__.py 98.07% <100.00%> (+0.07%) ⬆️
onnxscript/onnx_opset/_impl/opset19.py 100.00% <100.00%> (ø)
...t/function_libs/torch_aten/ops_correctness_test.py 94.15% <100.00%> (+0.32%) ⬆️
onnxscript/test/converter_test.py 87.07% <0.00%> (-0.23%) ⬇️
onnxscript/autocast.py 98.07% <0.00%> (+1.92%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@justinchuby justinchuby merged commit 339a895 into main Jan 10, 2023
@justinchuby justinchuby deleted the justinchu/log branch January 10, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants