Conversation
justinchuby
added
the
module: torchlib
Closed
justinchuby
changed the title
Codecov Report
@@ Coverage Diff @@
## main #286 +/- ##
==========================================
+ Coverage 72.15% 72.73% +0.57%
==========================================
Files 95 95
Lines 9055 9063 +8
==========================================
+ Hits 6534 6592 +58
+ Misses 2521 2471 -50
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fatcat-z
reviewed
Jan 6, 2023
| "exp": core_ops.aten_exp, | ||
| "exp2": core_ops.aten_exp2, | ||
| "fmod": core_ops.aten_fmod, | ||
| "full_like": core_ops.aten_full_like, |
Contributor
There was a problem hiding this comment.
Why don't we add aten::full here?
Collaborator
Author
There was a problem hiding this comment.
we don't have an OpInfo for full so... I think it is innocuous enough to not include it for now?
Collaborator
Author
There was a problem hiding this comment.
I added a todo inline to note.
xiaowuhu
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement where, full, new_full, full_like