Add a new op embedding.

[fatcat-z]

Add a new op embeding and its test.

[codecov]

Codecov Report

Merging #306 (f80920b) into main (edfa7c1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head f80920b differs from pull request most recent head 78f075d. Consider uploading reports for the commit 78f075d to get more accurate results

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   72.92%   72.95%   +0.02%     
==========================================
  Files          97       97              
  Lines        9445     9446       +1     
==========================================
+ Hits         6888     6891       +3     
+ Misses       2557     2555       -2     

Impacted Files	Coverage Δ
...t/function_libs/torch_aten/ops_correctness_test.py	95.53% <ø> (ø)
onnxscript/function_libs/torch_aten/ops/core.py	62.61% <100.00%> (+0.09%)	⬆️
onnxscript/converter.py	91.33% <0.00%> (+0.13%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[justinchuby]

Suggested change

	**kwargs,# pylint: disable=unused-argument
	**_,

Don’t know if ** works in onnxscript, but if it does:

[justinchuby]

Do we need to change behavior based on padding_idx?

[fatcat-z]

According to current implementation, it will only impact Training. I think ONNX Script won't know if current export is under Training mode, so the warning about possible wrong training result should be thrown by exporter, not onnx-script.

Thoughts?

[justinchuby]

I think we should also support any training behaviors when possible.

[justinchuby]

@gramalingam so variadic keyword arguments are supported?