Skip to content

test(atenlib): split mappings to two #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 12, 2023
Merged

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Jan 11, 2023

Split the scripted and traced ops and added a test to make sure we compiled all functions.

@justinchuby justinchuby marked this pull request as draft January 11, 2023 04:31
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Jan 11, 2023
@justinchuby justinchuby changed the title test: split mappings to two test(atenlib): split mappings to two Jan 11, 2023
@justinchuby justinchuby marked this pull request as ready for review January 12, 2023 03:07
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #308 (739b39b) into main (91701fa) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
+ Coverage   72.86%   72.89%   +0.02%     
==========================================
  Files          97       97              
  Lines        9426     9436      +10     
==========================================
+ Hits         6868     6878      +10     
  Misses       2558     2558              
Impacted Files Coverage Δ
onnxscript/test/onnx_backend_test.py 73.07% <ø> (ø)
onnxscript/function_libs/torch_aten/ops/core.py 62.21% <100.00%> (+0.05%) ⬆️
...t/function_libs/torch_aten/ops_correctness_test.py 95.53% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@justinchuby justinchuby merged commit cf27ba8 into main Jan 12, 2023
@justinchuby justinchuby deleted the justinchu/test-split branch January 12, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants