Skip to content

add ops: ge, le, maxmium, minmium, softmax #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 13, 2023
Merged

add ops: ge, le, maxmium, minmium, softmax #313

merged 5 commits into from
Jan 13, 2023

Conversation

xiaowuhu
Copy link
Contributor

No description provided.

@xiaowuhu xiaowuhu marked this pull request as draft January 13, 2023 05:52
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #313 (f18d2cc) into main (b29a9fe) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   72.95%   73.04%   +0.09%     
==========================================
  Files          97       97              
  Lines        9446     9461      +15     
==========================================
+ Hits         6891     6911      +20     
+ Misses       2555     2550       -5     
Impacted Files Coverage Δ
onnxscript/function_libs/torch_aten/ops/core.py 62.98% <100.00%> (+0.37%) ⬆️
onnxscript/function_libs/torch_aten/ops/special.py 62.41% <100.00%> (+3.01%) ⬆️
...t/function_libs/torch_aten/ops_correctness_test.py 95.60% <100.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xiaowuhu xiaowuhu changed the title (draft)add ge op add ops: ge, maxmium, softmax Jan 13, 2023
@xiaowuhu xiaowuhu changed the title add ops: ge, maxmium, softmax add ops: ge, le, maxmium, minmium, softmax Jan 13, 2023
@xiaowuhu xiaowuhu marked this pull request as ready for review January 13, 2023 09:18
@xiaowuhu xiaowuhu mentioned this pull request Jan 13, 2023
@xiaowuhu xiaowuhu requested a review from justinchuby January 13, 2023 11:37
Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@justinchuby justinchuby merged commit dfaf174 into microsoft:main Jan 13, 2023
@justinchuby
Copy link
Collaborator

Wait: ge and le should be greater/less than or equal to. We are using greater/less here. I merged prematurely @xiaowuhu

@justinchuby justinchuby mentioned this pull request Jan 14, 2023
@xiaowuhu xiaowuhu deleted the xiaowu/addOps(5) branch January 18, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants