Skip to content

feat(atenlib): add op(max) #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Mar 1, 2023
Merged

feat(atenlib): add op(max) #314

merged 32 commits into from
Mar 1, 2023

Conversation

xiaowuhu
Copy link
Contributor

No description provided.

@xiaowuhu xiaowuhu marked this pull request as draft January 13, 2023 09:24
@xiaowuhu xiaowuhu changed the title Xiaowu/add op(mean) (draft)Xiaowu/add op(mean) Jan 13, 2023
@xiaowuhu xiaowuhu changed the title (draft)Xiaowu/add op(mean) feat(atenlib): add op(max) Feb 28, 2023
@xiaowuhu xiaowuhu marked this pull request as ready for review February 28, 2023 11:55
@codecov
Copy link

codecov bot commented Mar 1, 2023 •
edited
Loading

Codecov Report

Merging #314 (0daa0a1) into main (ba1c324) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
- Coverage   72.58%   72.37%   -0.22%     
==========================================
  Files         109      109              
  Lines       10547    10580      +33     
  Branches     1082     1089       +7     
==========================================
+ Hits         7656     7657       +1     
- Misses       2589     2616      +27     
- Partials      302      307       +5
Impacted Files Coverage Δ
...s/function_libs/torch_aten/ops_correctness_test.py 90.22% <ø> (+2.22%) ⬆️
onnxscript/function_libs/torch_aten/ops/core.py 69.50% <100.00%> (+0.63%) ⬆️
onnxscript/tests/models/onnxfns1A.py 68.88% <0.00%> (-26.67%) ⬇️
onnxscript/tests/functions/onnxfns1A_test.py 79.48% <0.00%> (-15.39%) ⬇️
onnxscript/tests/common/onnx_script_test_case.py 74.03% <0.00%> (-14.43%) ⬇️
onnxscript/utils.py 47.61% <0.00%> (-3.18%) ⬇️
onnxscript/tests/functions/onnxfns2_test.py 92.30% <0.00%> (-2.57%) ⬇️
onnxscript/tests/functions/onnxfns_test.py 93.02% <0.00%> (-2.33%) ⬇️
onnxscript/irbuilder.py 76.95% <0.00%> (-1.49%) ⬇️
onnxscript/tensor.py 83.92% <0.00%> (-0.90%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fatcat-z
fatcat-z approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@xiaowuhu xiaowuhu merged commit c5ca05b into microsoft:main Mar 1, 2023
@xiaowuhu xiaowuhu mentioned this pull request Mar 2, 2023
Open
justinchuby
justinchuby reviewed Mar 4, 2023
View reviewed changes
onnxscript/function_libs/torch_aten/ops/core.py


@torch_op("aten::max", overload=True)
# def _aten_max_with_dim(self: TReal, dim: int, keepdim: bool) -> tuple[TReal, TInt]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Dead code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby left review comments

@titaiwangms titaiwangms titaiwangms left review comments

@fatcat-z fatcat-z fatcat-z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaowuhu @justinchuby @titaiwangms @fatcat-z