Skip to content

feat(atenlib): add ops(gelu, celu) #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jan 18, 2023
Merged

feat(atenlib): add ops(gelu, celu) #323

merged 16 commits into from
Jan 18, 2023

Conversation

xiaowuhu
Copy link
Contributor

@xiaowuhu xiaowuhu commented Jan 16, 2023 •
edited
Loading

add GELU,CELU op

@xiaowuhu xiaowuhu mentioned this pull request Jan 16, 2023
Open
@codecov
Copy link

codecov bot commented Jan 16, 2023 •
edited
Loading

Codecov Report

Merging #323 (18619e2) into main (000d657) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   73.24%   73.31%   +0.06%     
==========================================
  Files          96       96              
  Lines        9495     9512      +17     
==========================================
+ Hits         6955     6974      +19     
+ Misses       2540     2538       -2
Impacted Files Coverage Δ
...t/function_libs/torch_aten/ops_correctness_test.py 95.76% <ø> (ø)
onnxscript/function_libs/torch_aten/ops/nn.py 59.93% <100.00%> (+2.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xiaowuhu xiaowuhu changed the title Xiaowu/add ops(gelu) Xiaowu/add ops(gelu, celu) Jan 16, 2023
justinchuby
justinchuby reviewed Jan 16, 2023
View reviewed changes
@justinchuby justinchuby changed the title Xiaowu/add ops(gelu, celu) feat(atenlib): add ops(gelu, celu) Jan 17, 2023
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Jan 17, 2023
@justinchuby justinchuby self-assigned this Jan 17, 2023
justinchuby
justinchuby approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with wrangler and reverting the edit in values.py

@xiaowuhu xiaowuhu merged commit 34359e8 into microsoft:main Jan 18, 2023
@xiaowuhu xiaowuhu deleted the xiaowu/addOps(7) branch January 18, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

@fatcat-z fatcat-z Awaiting requested review from fatcat-z

Assignees
No one assigned
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaowuhu @justinchuby @fatcat-z