feat(atenlib): add ops (ArgMax, ArgMin, Detach) #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Open
xiaowuhu
changed the title
Codecov Report
@@ Coverage Diff @@
## main #324 +/- ##
==========================================
+ Coverage 73.17% 73.24% +0.07%
==========================================
Files 96 96
Lines 9476 9495 +19
==========================================
+ Hits 6934 6955 +21
+ Misses 2542 2540 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
justinchuby
reviewed
Jan 17, 2023
justinchuby
reviewed
Jan 17, 2023
justinchuby
reviewed
Jan 17, 2023
onnxscript/test/function_libs/torch_aten/ops_correctness_test.py
Outdated
Show resolved
Hide resolved
justinchuby
changed the title
justinchuby
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ops: argmax, argmin, but use trace_only = True mode, due to OptionalHasElement(dim) cannot work now.