feat(atenlib): add ops(native_layer_norm) #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaowuhu
changed the title
xiaowuhu
added
the
module: torchlib
Codecov Report
@@ Coverage Diff @@
## main #330 +/- ##
==========================================
- Coverage 73.31% 73.28% -0.04%
==========================================
Files 96 96
Lines 9512 9526 +14
==========================================
+ Hits 6974 6981 +7
- Misses 2538 2545 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
justinchuby
approved these changes
Jan 18, 2023
| # native_layer_norm(Tensor input, SymInt[] normalized_shape, Tensor? weight, Tensor? bias, float eps) -> (Tensor, Tensor, Tensor) | ||
|
|
||
| raise NotImplementedError() | ||
| axes = [-i for i in range(len(normalized_shape), 0, -1)] |
There was a problem hiding this comment.
normalized_shape should be a tensor so use onnx op on it? In test we can make normalized_shape to always be a tensor.
Alternatively, annotate normalized_shape to be int for now?
There was a problem hiding this comment.
will check it later.
justinchuby
changed the title
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using opset17 inside the function to pass the testing, due to opset18 is not ready yet.