Skip to content

feat(atenlib): add ops(sum)#348

Merged
xiaowuhu merged 5 commits intomainfrom
xiaowu/add-ops(sum)
Jan 20, 2023
Merged

feat(atenlib): add ops(sum)#348
xiaowuhu merged 5 commits intomainfrom
xiaowu/add-ops(sum)

Conversation

@xiaowuhu
Copy link
Copy Markdown
Contributor

@xiaowuhu xiaowuhu commented Jan 20, 2023

add op: sum with trace_only = True, due to OptionalHasElement() cannot work now

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 20, 2023

Codecov Report

Merging #348 (58e0c44) into main (284bcb6) will increase coverage by 0.05%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
+ Coverage   73.40%   73.46%   +0.05%     
==========================================
  Files          96       96              
  Lines        9612     9633      +21     
==========================================
+ Hits         7056     7077      +21     
  Misses       2556     2556              
Impacted Files Coverage Δ
onnxscript/function_libs/torch_aten/ops/core.py 63.84% <93.33%> (+0.33%) ⬆️
...t/function_libs/torch_aten/ops_correctness_test.py 96.11% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xiaowuhu xiaowuhu requested a review from justinchuby January 20, 2023 04:08
@xiaowuhu xiaowuhu mentioned this pull request Jan 20, 2023
@xiaowuhu xiaowuhu requested review from justinchuby and removed request for justinchuby January 20, 2023 04:19
Copy link
Copy Markdown
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@xiaowuhu xiaowuhu merged commit 4e51e58 into main Jan 20, 2023
@xiaowuhu xiaowuhu deleted the xiaowu/add-ops(sum) branch January 20, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants