Skip to content

Add several new ops relative to convolution. #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 13, 2023

Conversation

fatcat-z
Copy link
Contributor

@fatcat-z fatcat-z commented Feb 11, 2023

Add below aten ops and their tests into library:

conv1d
conv3d

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #431 (395da4d) into main (227cb71) will increase coverage by 0.08%.
The diff coverage is 90.24%.

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   71.18%   71.26%   +0.08%     
==========================================
  Files         108      108              
  Lines       10441    10480      +39     
  Branches     1078     1087       +9     
==========================================
+ Hits         7432     7469      +37     
  Misses       2700     2700              
- Partials      309      311       +2     
Impacted Files Coverage Δ
...s/function_libs/torch_aten/ops_correctness_test.py 90.33% <ø> (ø)
onnxscript/function_libs/torch_aten/ops/core.py 67.43% <88.23%> (+0.50%) ⬆️
...ipt/tests/function_libs/torch_aten/extra_opinfo.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Was there issue with conv transpose?

@fatcat-z fatcat-z merged commit 3a12dfe into microsoft:main Feb 13, 2023
@fatcat-z fatcat-z deleted the new_conv_trans_op branch February 13, 2023 16:06
@fatcat-z
Copy link
Contributor Author

Nice, thanks! Was there issue with conv transpose?

Yes, let's discuss it in today's meeting.

@fatcat-z fatcat-z mentioned this pull request Feb 13, 2023
@fatcat-z fatcat-z added the module: torchlib Related to the torch/aten function lib in development label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants