Skip to content

feat(atenlib): add ops(nll_loss) #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 58 commits into from
Mar 15, 2023
Merged

feat(atenlib): add ops(nll_loss) #453

merged 58 commits into from
Mar 15, 2023

Conversation

xiaowuhu
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #453 (1558288) into main (7534a16) will increase coverage by 0.09%.
The diff coverage is 97.50%.

@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
+ Coverage   73.60%   73.70%   +0.09%     
==========================================
  Files         109      109              
  Lines       10821    10860      +39     
  Branches     1115     1127      +12     
==========================================
+ Hits         7965     8004      +39     
+ Misses       2551     2550       -1     
- Partials      305      306       +1     
Impacted Files Coverage Δ
...s/function_libs/torch_aten/ops_correctness_test.py 90.11% <88.88%> (-0.04%) ⬇️
onnxscript/function_libs/torch_aten/ops/nn.py 65.22% <100.00%> (+3.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@justinchuby justinchuby requested a review from fatcat-z February 20, 2023 18:53
@xiaowuhu xiaowuhu mentioned this pull request Feb 21, 2023
@xiaowuhu xiaowuhu changed the title (draft)feat(atenlib): add ops(nll_loss) feat(atenlib): add ops(nll_loss) Feb 21, 2023
@justinchuby
Copy link
Collaborator

There’s some comments

@justinchuby
Copy link
Collaborator

I see what's happening. Let me think about this

@justinchuby
Copy link
Collaborator

@shubhambhokare1 I think your PR on optional support will be very useful for this

@justinchuby justinchuby self-assigned this Mar 8, 2023
@justinchuby
Copy link
Collaborator

For this op, can we skip when weight is None for now and add a fix me? I will need to spend some time to make the check right.

@xiaowuhu xiaowuhu merged commit ccf5586 into microsoft:main Mar 15, 2023
@xiaowuhu xiaowuhu deleted the xiaowu/addOps(0220) branch March 15, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants