-
Notifications
You must be signed in to change notification settings - Fork 64
feat(atenlib): add ops(nll_loss) #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #453 +/- ##
==========================================
+ Coverage 73.60% 73.70% +0.09%
==========================================
Files 109 109
Lines 10821 10860 +39
Branches 1115 1127 +12
==========================================
+ Hits 7965 8004 +39
+ Misses 2551 2550 -1
- Partials 305 306 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
onnxscript/tests/function_libs/torch_aten/ops_correctness_test.py
Outdated
Show resolved
Hide resolved
onnxscript/tests/function_libs/torch_aten/ops_correctness_test.py
Outdated
Show resolved
Hide resolved
onnxscript/tests/function_libs/torch_aten/ops_correctness_test.py
Outdated
Show resolved
Hide resolved
There’s some comments |
I see what's happening. Let me think about this |
@shubhambhokare1 I think your PR on optional support will be very useful for this |
For this op, can we skip when |
No description provided.