Skip to content

feat(atenlib): add ops(resolve_conj, resolve_neg) #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2023
Merged

feat(atenlib): add ops(resolve_conj, resolve_neg) #458

merged 4 commits into from
Feb 23, 2023

Conversation

xiaowuhu
Copy link
Contributor

No description provided.

@xiaowuhu xiaowuhu mentioned this pull request Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #458 (b3e4c38) into main (6c5f9a8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   72.02%   72.05%   +0.02%     
==========================================
  Files         109      109              
  Lines       10504    10506       +2     
  Branches     1075     1075              
==========================================
+ Hits         7566     7570       +4     
+ Misses       2635     2633       -2     
  Partials      303      303              
Impacted Files Coverage Δ
...s/function_libs/torch_aten/ops_correctness_test.py 87.92% <ø> (ø)
onnxscript/function_libs/torch_aten/ops/core.py 67.48% <100.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Feb 22, 2023
@@ -4641,16 +4641,18 @@ def aten_reshape_as(self: TensorType, other: TensorType) -> TensorType:
raise NotImplementedError()


def aten_resolve_conj(self: TensorType) -> TensorType:
@torch_op("aten::resolve_conj")
def aten_resolve_conj(self: TTensor) -> TensorType:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def aten_resolve_conj(self: TTensor) -> TensorType:
def aten_resolve_conj(self: TTensor) -> TTensor:



def aten_resolve_neg(self: TensorType) -> TensorType:
@torch_op("aten::resolve_neg")
def aten_resolve_neg(self: TTensor) -> TensorType:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def aten_resolve_neg(self: TTensor) -> TensorType:
def aten_resolve_neg(self: TTensor) -> TTensor:

@justinchuby justinchuby changed the title feat(atenlib) add ops(resolve_conj, resolve_neg) feat(atenlib): add ops(resolve_conj, resolve_neg) Feb 22, 2023
@xiaowuhu xiaowuhu merged commit b5ca6f7 into microsoft:main Feb 23, 2023
@xiaowuhu xiaowuhu deleted the xiaowu/addOp(resolve_x) branch February 23, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants