Skip to content

feat(atenlib): add ops(squeeze) #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 28, 2023
Merged

feat(atenlib): add ops(squeeze) #460

merged 11 commits into from
Feb 28, 2023

Conversation

xiaowuhu
Copy link
Contributor

No description provided.

@xiaowuhu xiaowuhu mentioned this pull request Feb 22, 2023
@xiaowuhu xiaowuhu changed the title feat(atenlib): add ops(squeeze) [draft]feat(atenlib): add ops(squeeze) Feb 22, 2023
@xiaowuhu xiaowuhu changed the title [draft]feat(atenlib): add ops(squeeze) feat(atenlib): add ops(squeeze) Feb 26, 2023
@xiaowuhu xiaowuhu requested a review from fatcat-z February 26, 2023 09:41
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #460 (9f6a682) into main (925e81c) will decrease coverage by 1.57%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   72.58%   71.02%   -1.57%     
==========================================
  Files         109      107       -2     
  Lines       10547    10491      -56     
  Branches     1082     1072      -10     
==========================================
- Hits         7656     7451     -205     
- Misses       2589     2733     +144     
- Partials      302      307       +5     
Impacted Files Coverage Δ
...s/function_libs/torch_aten/ops_correctness_test.py 85.33% <ø> (-2.67%) ⬇️
onnxscript/function_libs/torch_aten/ops/core.py 69.07% <100.00%> (+0.19%) ⬆️
...pt/function_libs/torch_aten/graph_building_test.py 30.90% <0.00%> (-58.19%) ⬇️
...xscript/function_libs/torch_aten/graph_building.py 33.47% <0.00%> (-35.20%) ⬇️
onnxscript/tests/models/onnxfns1A.py 68.88% <0.00%> (-26.67%) ⬇️
onnxscript/tests/functions/onnxfns1A_test.py 79.48% <0.00%> (-15.39%) ⬇️
onnxscript/tests/common/onnx_script_test_case.py 74.03% <0.00%> (-14.43%) ⬇️
onnxscript/testing.py 50.92% <0.00%> (-3.71%) ⬇️
onnxscript/utils.py 47.61% <0.00%> (-3.18%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@xiaowuhu xiaowuhu merged commit 87226d2 into microsoft:main Feb 28, 2023
@xiaowuhu xiaowuhu deleted the xiaowu/addOp(squeeze) branch February 28, 2023 10:28
@titaiwangms
Copy link
Contributor

titaiwangms commented Feb 28, 2023

@xiaowuhu I think this op is breaking CI test. Could you take a look? Please check torch-nightly branch

@xiaowuhu xiaowuhu restored the xiaowu/addOp(squeeze) branch March 1, 2023 02:00
xiaowuhu added a commit that referenced this pull request Mar 1, 2023
xiaowuhu added a commit that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants