feat(atenlib): aten_expand supports -1 dim #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #483 +/- ##
=======================================
Coverage 72.45% 72.45%
=======================================
Files 109 109
Lines 10601 10602 +1
Branches 1093 1093
=======================================
+ Hits 7681 7682 +1
Misses 2613 2613
Partials 307 307
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gramalingam
approved these changes
Mar 1, 2023
titaiwangms
added
the
module: torchlib
Collaborator
|
Are there tests we can enable for this? |
Contributor
Author
Thinking about parametrizing fx-export into runtime test. |
Collaborator
|
Was there an OpInfo covering this case? |
justinchuby
reviewed
Mar 4, 2023
|
|
||
| size = op.Cast(size, to=INT64.dtype) | ||
| # To support -1 dim. | ||
| size = op.Abs(size) |
Collaborator
There was a problem hiding this comment.
I understand -1 becomes 1. Was that intended or was I missing something?
Contributor
Author
There was a problem hiding this comment.
Only -1 becomes 1. Do you think comment is redundant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.