Skip to content

feat(atenlib):add ops(scalar tensor, constant_pad_nd) #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Mar 8, 2023
Merged

feat(atenlib):add ops(scalar tensor, constant_pad_nd) #492

merged 22 commits into from
Mar 8, 2023

Conversation

xiaowuhu
Copy link
Contributor

@xiaowuhu xiaowuhu commented Mar 2, 2023

No description provided.

@xiaowuhu xiaowuhu requested a review from fatcat-z March 2, 2023 10:59
@xiaowuhu xiaowuhu mentioned this pull request Mar 2, 2023
Closed
@codecov
Copy link

codecov bot commented Mar 2, 2023 •
edited
Loading

Codecov Report

Merging #492 (ec71d05) into main (a6accf0) will increase coverage by 0.05%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
+ Coverage   72.39%   72.44%   +0.05%     
==========================================
  Files         109      109              
  Lines       10638    10656      +18     
  Branches     1100     1100              
==========================================
+ Hits         7701     7720      +19     
+ Misses       2630     2629       -1     
  Partials      307      307
Impacted Files Coverage Δ
...s/function_libs/torch_aten/ops_correctness_test.py 87.93% <ø> (ø)
onnxscript/function_libs/torch_aten/ops/core.py 70.40% <95.45%> (+0.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gramalingam
gramalingam reviewed Mar 3, 2023
View reviewed changes
gramalingam
gramalingam reviewed Mar 3, 2023
View reviewed changes
xiaowuhu added 15 commits March 6, 2023 14:15
justinchuby
justinchuby reviewed Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@justinchuby justinchuby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thank you! Love the clean implementation. Some minor comments

@justinchuby
Copy link
Collaborator

justinchuby commented Mar 7, 2023 •
edited
Loading

Would be great to get a second review from @fatcat-z

fatcat-z
fatcat-z approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@fatcat-z fatcat-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@xiaowuhu xiaowuhu merged commit 869c9ee into microsoft:main Mar 8, 2023
@xiaowuhu xiaowuhu deleted the xiaowu/addOps(scalar_tensor) branch March 8, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam left review comments

@justinchuby justinchuby justinchuby approved these changes

@fatcat-z fatcat-z fatcat-z approved these changes

Assignees

@fatcat-z fatcat-z

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaowuhu @justinchuby @gramalingam @fatcat-z