feat(atenlib): add Op(isclose, allclose) #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #526 +/- ##
==========================================
+ Coverage 73.71% 73.75% +0.04%
==========================================
Files 109 109
Lines 10873 10882 +9
Branches 1131 1131
==========================================
+ Hits 8015 8026 +11
+ Misses 2553 2551 -2
Partials 305 305
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Closed
justinchuby
reviewed
Mar 15, 2023
| EXPECTED_SKIPS_OR_FAILS = ( | ||
| xfail( | ||
| "allclose", | ||
| reason="allclose return Tenosr(BOOL) but torch return Scalar(bool)", |
Collaborator
There was a problem hiding this comment.
We can convert the torch output back to a tensor for comparison. I remember this has been done already?
Collaborator
|
@xiaowuhu I added |
Collaborator
|
I changed to use INT8 and ReduceMin. Hopefully that's more efficient |
Collaborator
|
@xiaowuhu i think this is ready. Only a minor formatting error |
justinchuby
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.