Skip to content

feat(atenlib): addOp(new_ones, new_zeros) #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 22, 2023
Merged

feat(atenlib): addOp(new_ones, new_zeros) #535

merged 7 commits into from
Mar 22, 2023

Conversation

xiaowuhu
Copy link
Contributor

@xiaowuhu xiaowuhu commented Mar 20, 2023

torch 2.0 CI failed.

@xiaowuhu xiaowuhu mentioned this pull request Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #535 (cf96f77) into main (b0da015) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
+ Coverage   73.72%   73.78%   +0.05%     
==========================================
  Files         109      109              
  Lines       10946    10962      +16     
  Branches     1136     1136              
==========================================
+ Hits         8070     8088      +18     
+ Misses       2568     2566       -2     
  Partials      308      308              
Impacted Files Coverage Δ
onnxscript/function_libs/torch_aten/ops/core.py 72.14% <100.00%> (+0.30%) ⬆️
...s/function_libs/torch_aten/ops_correctness_test.py 89.73% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-advanced-security
Copy link

You have successfully added a new lintrunner configuration lintrunner. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Mar 20, 2023
@justinchuby
Copy link
Collaborator

Failures should be fixed by microsoft/onnxruntime#15130. We should pull in ort nightly to test

@justinchuby
Copy link
Collaborator

I would xfail the tests for now

@justinchuby justinchuby merged commit 1e8d764 into main Mar 22, 2023
@justinchuby justinchuby deleted the xiaowu/addOp branch March 22, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants