Skip to content

feat(atenlib): add Op(mse_loss) #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 23, 2023
Merged

feat(atenlib): add Op(mse_loss) #536

merged 12 commits into from
Mar 23, 2023

Conversation

xiaowuhu
Copy link
Contributor

@xiaowuhu xiaowuhu commented Mar 20, 2023

torch nightly (torch 2.0) CI failed

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #536 (7ddaab7) into main (1e8d764) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   73.78%   73.82%   +0.04%     
==========================================
  Files         109      109              
  Lines       10962    10975      +13     
  Branches     1136     1139       +3     
==========================================
+ Hits         8088     8102      +14     
+ Misses       2566     2565       -1     
  Partials      308      308              
Impacted Files Coverage Δ
onnxscript/function_libs/torch_aten/ops/nn.py 66.04% <100.00%> (+0.81%) ⬆️
...s/function_libs/torch_aten/ops_correctness_test.py 89.94% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xiaowuhu xiaowuhu mentioned this pull request Mar 20, 2023
@github-advanced-security
Copy link

You have successfully added a new lintrunner configuration lintrunner. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Mar 20, 2023
@justinchuby
Copy link
Collaborator

justinchuby commented Mar 21, 2023

Feel free to link the ONNX issue to this PR if one was created

@xiaowuhu
Copy link
Contributor Author

xiaowuhu commented Mar 22, 2023

Linked to this issue: onnx/onnx#5029

@justinchuby
Copy link
Collaborator

I think it’s fine to add an xfail for now

@xiaowuhu xiaowuhu merged commit 21849ad into main Mar 23, 2023
@xiaowuhu xiaowuhu deleted the xiaowu/addOps(mse_loss) branch March 23, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants