Skip to content

feat(atenlib): addOp(var,vardim,varcorrection) #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 14, 2023
Merged

Conversation

xiaowuhu
Copy link
Contributor

@xiaowuhu xiaowuhu commented Mar 28, 2023

File an bug for onnx:
onnx/onnx#5125

@xiaowuhu xiaowuhu marked this pull request as draft March 28, 2023 11:36
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #569 (61617b0) into main (a9fc6ca) will increase coverage by 0.08%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
+ Coverage   74.30%   74.39%   +0.08%     
==========================================
  Files         107      107              
  Lines       11333    11383      +50     
  Branches     1178     1185       +7     
==========================================
+ Hits         8421     8468      +47     
- Misses       2590     2591       +1     
- Partials      322      324       +2     
Impacted Files Coverage Δ
onnxscript/function_libs/torch_aten/ops/core.py 74.25% <92.15%> (+0.47%) ⬆️
...s/function_libs/torch_aten/ops_correctness_test.py 88.83% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xiaowuhu xiaowuhu changed the title [draft]feat(atenlib): addOp(var,vardim,varcorrection) feat(atenlib): addOp(var,vardim,varcorrection) Apr 13, 2023
@xiaowuhu xiaowuhu marked this pull request as ready for review April 13, 2023 03:39
@justinchuby justinchuby self-requested a review April 13, 2023 23:50
Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clicked approve prematurely. Resetting for now

@xiaowuhu xiaowuhu merged commit 8bd7995 into main Apr 14, 2023
@xiaowuhu xiaowuhu deleted the xiaowu/addOp(var) branch April 14, 2023 05:30
justinchuby added a commit that referenced this pull request Apr 15, 2023
justinchuby added a commit that referenced this pull request Apr 15, 2023
@xiaowuhu xiaowuhu restored the xiaowu/addOp(var) branch April 17, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants