-
Notifications
You must be signed in to change notification settings - Fork 72
feat(atenlib): addOp(var,vardim,varcorrection) #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #569 +/- ##
==========================================
+ Coverage 74.30% 74.39% +0.08%
==========================================
Files 107 107
Lines 11333 11383 +50
Branches 1178 1185 +7
==========================================
+ Hits 8421 8468 +47
- Misses 2590 2591 +1
- Partials 322 324 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fatcat-z
reviewed
Apr 13, 2023
justinchuby
reviewed
Apr 13, 2023
justinchuby
reviewed
Apr 13, 2023
justinchuby
reviewed
Apr 13, 2023
justinchuby
approved these changes
Apr 13, 2023
onnxscript/tests/function_libs/torch_aten/ops_correctness_test.py
Outdated
Show resolved
Hide resolved
justinchuby
requested changes
Apr 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I clicked approve prematurely. Resetting for now
justinchuby
approved these changes
Apr 14, 2023
justinchuby
added a commit
that referenced
this pull request
Apr 15, 2023
This reverts commit 8bd7995.
justinchuby
added a commit
that referenced
this pull request
Apr 15, 2023
Reverts #569 due to #634 Co-authored-by: xiaowuhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File an bug for onnx:
onnx/onnx#5125