Skip to content

Move version_utils to _internal | chore #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Apr 12, 2023

Move version_utils to `_internal` so that it can be used my onnxscript

[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Apr 12, 2023
Move version_utils to `_internal` so that it can be used my onnxscript

ghstack-source-id: a566f1c
Pull Request resolved: #624
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #624 (c6505cf) into main (e990f23) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #624   +/-   ##
=======================================
  Coverage   74.28%   74.28%           
=======================================
  Files         107      107           
  Lines       11330    11333    +3     
  Branches     1179     1179           
=======================================
+ Hits         8416     8419    +3     
  Misses       2591     2591           
  Partials      323      323           
Impacted Files Coverage Δ
onnxscript/_internal/version_utils.py 100.00% <ø> (ø)
...pt/function_libs/torch_aten/graph_building_test.py 89.09% <100.00%> (ø)
...s/function_libs/torch_aten/ops_correctness_test.py 88.81% <100.00%> (ø)
onnxscript/tests/functions/onnxfns1A_test.py 85.45% <100.00%> (+0.26%) ⬆️
onnxscript/tests/functions/onnxfns2_test.py 94.73% <100.00%> (+0.14%) ⬆️
onnxscript/tests/functions/onnxfns_test.py 93.47% <100.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@justinchuby justinchuby changed the base branch from gh/justinchuby/14/base to main April 12, 2023 18:07
@justinchuby justinchuby merged commit 3aacfbe into main Apr 12, 2023
@justinchuby justinchuby deleted the gh/justinchuby/14/head branch April 12, 2023 18:08
@justinchuby justinchuby restored the gh/justinchuby/14/head branch April 12, 2023 18:09
@justinchuby justinchuby deleted the gh/justinchuby/14/head branch March 13, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants