Implement split_function_and_wrangler | test(torchlib) #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

justinchuby merged 55 commits into main from gh/justinchuby/22/head

Apr 27, 2023

+21 −23

Collaborator

justinchuby commented Apr 27, 2023 •

edited

Loading

Stack from ghstack (oldest at bottom):

justinchuby added 30 commits

April 12, 2023 17:30


          Move version_utils to _internal | chore

c6505cf

Move version_utils to `_internal` so that it can be used my onnxscript

[ghstack-poisoned]


          Merge attrs and attr_protos in IRFunction | chore(irbuilder)

268ad8f

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

1f900c1

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

01f9378

…builder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

1b7391e

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

304fa0d

…builder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

ac60dce

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

3eb45c6

…builder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

f7b9b79

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

59523f5

…builder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

758ce59

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

fdd2f22

…builder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

d4b0db6

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

cc977b1

…builder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

8ffd7e7

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

831a416

…builder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

1fd4d2e

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

62105f3

…builder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

9c6bfae

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

c63ccd5

…builder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Analyze type annotation for input types | feat(op_schema)

4e38a29

[ghstack-poisoned]


          Update on "Analyze type annotation for input types | feat(op_schema)"

b34551c

[ghstack-poisoned]


          Update base for Update on "Analyze type annotation for input types | …

f3911bf

…feat(op_schema)"

[ghstack-poisoned]


          Update on "Analyze type annotation for input types | feat(op_schema)"

b48d6ef

[ghstack-poisoned]


          Update base for Update on "Analyze type annotation for input types | …

…feat(op_schema)"

[ghstack-poisoned]


          Update on "Analyze type annotation for input types | feat(op_schema)"

f6a934d

[ghstack-poisoned]


          Update base for Update on "Analyze type annotation for input types | …

…feat(op_schema)"

[ghstack-poisoned]


          Update on "Analyze type annotation for input types | feat(op_schema)"

40c29c6

[ghstack-poisoned]


          Update base for Update on "Analyze type annotation for input types | …

a80742f

…feat(op_schema)"

[ghstack-poisoned]


          Update on "Analyze type annotation for input types | feat(op_schema)"

509aea0

[ghstack-poisoned]

justinchuby added 9 commits

April 22, 2023 00:30


          Update base for Update on "Analyze type annotation for input types | …

d272e20

…feat(op_schema)"

[ghstack-poisoned]


          Update on "Analyze type annotation for input types | feat(op_schema)"

cbcf5b1

[ghstack-poisoned]


          Update base for Update on "Analyze type annotation for input types | …

ca76465

…feat(op_schema)"

[ghstack-poisoned]


          Update on "Analyze type annotation for input types | feat(op_schema)"

724c0ef

[ghstack-poisoned]


          Update base for Update on "Analyze type annotation for input types | …

5d8f60e

…feat(op_schema)"

[ghstack-poisoned]


          Update on "Analyze type annotation for input types | feat(op_schema)"

9d7d12f

[ghstack-poisoned]


          Update base for Update on "Analyze type annotation for input types | …

e61bffe

…feat(op_schema)"

[ghstack-poisoned]


          Update on "Analyze type annotation for input types | feat(op_schema)"

52c198e

[ghstack-poisoned]


          Implement split_function_and_wrangler | test(torchlib)

0f76ccf

[ghstack-poisoned]

This was referenced Apr 27, 2023

Analyze type annotation for input types | feat(op_schema) #631

Merged

Auto generate OpSchema for functions | feat(op_schema) #626

Merged

Refactor converter to isolate translate_function_signature logic | feat(converter) #684

Merged

Auto OpSchema for trace_only functions | feat(op_schema) #674

Merged

justinchuby requested a review from titaiwangms

April 27, 2023 04:10

justinchuby added module: torchlib change base before merge topic: testing labels

justinchuby mentioned this pull request

Create the OpLike protocol and refactor Op | feat(values) #692

Closed

titaiwangms approved these changes

View reviewed changes

justinchuby added a commit that referenced this pull request


          Implement split_function_and_wrangler | test(torchlib)

7ff5466

ghstack-source-id: 266c0f9
Pull Request resolved: #688

BowenBao approved these changes

View reviewed changes

onnxscript/tests/function_libs/torch_lib/ops_test.py Show resolved Hide resolved

gramalingam approved these changes

View reviewed changes

justinchuby added 2 commits

April 27, 2023 22:28


          Update base for Update on "Implement split_function_and_wrangler | te…

a46b481

…st(torchlib)"

[ghstack-poisoned]


          Update on "Implement split_function_and_wrangler | test(torchlib)"

b38c7bb

[ghstack-poisoned]

justinchuby changed the base branch from gh/justinchuby/22/base to main

April 27, 2023 22:29

justinchuby merged commit a05ab66 into main

justinchuby deleted the gh/justinchuby/22/head branch

April 27, 2023 22:41

justinchuby restored the gh/justinchuby/22/head branch

April 27, 2023 22:41

justinchuby added a commit that referenced this pull request


          Analyze type annotation for input types | feat(op_schema) (#631)

0b633ea

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #692
* #674
* #626
* #684
* __->__ #631
* #688

justinchuby deleted the gh/justinchuby/22/head branch

March 13, 2024 01:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change base before merge module: torchlib topic: testing