Skip to content

Update test pipelines | chore(ci) #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2023
Merged

Update test pipelines | chore(ci) #701

merged 2 commits into from
Apr 29, 2023

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby requested review from liqunfu and jcwchen and removed request for liqunfu April 29, 2023 04:20
@justinchuby justinchuby added topic: ci merge at lgtm Reviewers can merge when they approve labels Apr 29, 2023
@justinchuby justinchuby mentioned this pull request Apr 29, 2023
Merged
@justinchuby justinchuby merged commit 05341f2 into main Apr 29, 2023
@justinchuby justinchuby deleted the justinchu/update-ci branch April 29, 2023 14:23
justinchuby added a commit that referenced this pull request May 2, 2023
@justinchuby
Skip incompatible dtypes in op_test using OpSchema | test(torchlib) (#…
f141dae 
…700)

This requires ONNX 1.14. I am skipping the op test for ONNX<1.14
altogether.

I tested locally to make sure no float32 test is skipped with this
mechanism, and that it skips properly according to the type annotation.

Currently no new dtypes are enabled because there are too many failures.

Requires 
- #701 
- #698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liqunfu liqunfu liqunfu approved these changes

@jcwchen jcwchen jcwchen approved these changes

Assignees
No one assigned
Labels
merge at lgtm Reviewers can merge when they approve topic: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinchuby @liqunfu @jcwchen