Add op (unbind) | feat(torchlib) #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Codecov Report
@@ Coverage Diff @@
## main #831 +/- ##
=======================================
Coverage 76.23% 76.23%
=======================================
Files 113 113
Lines 13312 13316 +4
Branches 1321 1321
=======================================
+ Hits 10148 10152 +4
Misses 2838 2838
Partials 326 326
|
titaiwangms
added
the
module: torchlib
titaiwangms
reviewed
Jul 5, 2023
| if ( | ||
| op.name.startswith("split") | ||
| or op.name.startswith("chunk") | ||
| or op.name.startswith("unbind") |
There was a problem hiding this comment.
I suspect we can know look at the function signature for this?
There was a problem hiding this comment.
Oh yup. We can leverage on Opschema and get output dtype.
There was a problem hiding this comment.
I had a try yesterday but failed to find a clear solution.
justinchuby
approved these changes
Jul 5, 2023
Co-authored-by: Ti-Tai Wang <[email protected]>
BowenBao
reviewed
Jul 5, 2023
| core_ops.aten_unbind, | ||
| ).xfail( | ||
| dtypes=[torch.float16], | ||
| reason="fixme: SplitToSequence op inference failed. https://github.com/microsoft/onnxruntime/issues/16006", |
There was a problem hiding this comment.
nit: What is op inference? Is this the common issue of ORT missing impl for float16 dtype?
not blocking merge.
There was a problem hiding this comment.
My read is shape inference failed? I will test it on 1.15 and update the issue
There was a problem hiding this comment.
Yes. Updated the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unbind op into torch_lib functions.
Add tests as well.