Skip to content

Implement aten._local_scalar_dense | feat(torchlib) #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinchuby merged 8 commits into from
Jul 11, 2023
Merged

Implement aten._local_scalar_dense | feat(torchlib) #847

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
370154b
Implement aten._local_scalar_dense
wschin Jul 11, 2023
f1bb276
Polish and add tests
wschin Jul 11, 2023
2d8b8d2
Merge branch 'main' into wechi/_local_scalar_dense
wschin Jul 11, 2023
fbcb1f5
Fix a name
wschin Jul 11, 2023
19c02ee
Merge branch 'main' into wechi/_local_scalar_dense
wschin Jul 11, 2023
c6f455b
suppress lintwarning
wschin Jul 11, 2023
04b3d58
Merge branch 'wechi/_local_scalar_dense' of https://github.com/wschin…
wschin Jul 11, 2023
cc1d73c
move a comment
wschin Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions onnxscript/function_libs/torch_lib/ops/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@
_MATH_PI = math.pi


@torch_op("aten::_local_scalar_dense")
def aten__local_scalar_dense(self: TTensor) -> TTensor:
Copy link
Copy Markdown
Collaborator

@justinchuby justinchuby Jul 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a docstring with its aten signature from https://aka.ms/native-functions like other functions do (looks like it's _local_scalar_dense(Tensor self) -> Scalar. Would be nice to have a reference to its implementation or documentation too.


flattened = op.Reshape(self, op.Constant(value_ints=[-1]))
first_item_as_scalar = op.Gather(flattened, 0)
return first_item_as_scalar


@torch_op("aten::abs")
def aten_abs(self: TRealOrUInt8) -> TRealOrUInt8:
"""abs(Tensor self) -> Tensor"""
Expand Down