Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #893 +/- ##
==========================================
+ Coverage 76.70% 76.73% +0.03%
==========================================
Files 112 112
Lines 13524 13549 +25
Branches 1366 1369 +3
==========================================
+ Hits 10373 10397 +24
Misses 2810 2810
- Partials 341 342 +1
|
…oft/onnxscript into xiaowu/addOp(aten_unfold)
xiaowuhu
changed the title
justinchuby
reviewed
Jul 18, 2023
Collaborator
justinchuby
left a comment
justinchuby
left a comment
There was a problem hiding this comment.
LGTM. Would be good to get another review from @BowenBao
| self_rank = self_rank + 1 | ||
| # perm need to be list[int], so have to be generated in trace_only mode | ||
| perm = list(range(self_rank)) | ||
| perm.append(perm.pop(dimension + 1)) |
Collaborator
There was a problem hiding this comment.
Would be great to add a comment to explain this logic, thanks!
Collaborator
There was a problem hiding this comment.
Why do we do this though? What does it mean? Is there a reference logic?
Contributor
Author
There was a problem hiding this comment.
- similar but different in detail: https://github.com/pytorch/pytorch/blob/a8f40b39ce4f9fa9ffd90400b7d10ea4051d623a/torch/onnx/symbolic_opset12.py#L390
- the same logic:
justinchuby
added
the
module: torchlib
Closed
…oft/onnxscript into xiaowu/addOp(aten_unfold)
justinchuby
approved these changes
Jul 19, 2023
BowenBao
approved these changes
Jul 19, 2023
justinchuby
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from: #534