-
Notifications
You must be signed in to change notification settings - Fork 65
Add op(roll) | feat(torchlib) #905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #905 +/- ##
==========================================
+ Coverage 76.84% 76.91% +0.07%
==========================================
Files 112 112
Lines 13619 13669 +50
Branches 1386 1397 +11
==========================================
+ Hits 10466 10514 +48
+ Misses 2805 2804 -1
- Partials 348 351 +3
|
dims is a Sequence that is by default empty: int[1] dims=[]. It will not be None, or an int. |
LGTM. The last batch of comments mostly around updating the signature/logic to match the aten signature. |
I also tried https://github.com/microsoft/onnxscript/pull/918/files only to realize concat doesn't take a dynamic axis |
Thank you! |
In
_roll_input_wrangler
:shifts
from int to tensordims
from int or tensor to attributes list, so we can use loop in trace_only mode to processaten_roll(x, (y1, y2), (z1, z2))
case.