Skip to content

Remove skips in scaled_dot_product_attention | test(torchlib) #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2023
Merged

Remove skips in scaled_dot_product_attention | test(torchlib) #970

merged 2 commits into from
Aug 5, 2023

Conversation

justinchuby
Copy link
Collaborator

Fixes #968

@justinchuby justinchuby requested a review from titaiwangms August 4, 2023 23:17
@justinchuby justinchuby added the module: torchlib Related to the torch/aten function lib in development label Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023 •
edited
Loading

Codecov Report

Merging #970 (c477cc6) into main (2f39b94) will increase coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
+ Coverage   76.86%   77.23%   +0.36%     
==========================================
  Files         112      112              
  Lines       13936    13936              
  Branches     1437     1437              
==========================================
+ Hits        10712    10763      +51     
+ Misses       2873     2819      -54     
- Partials      351      354       +3
Files Changed Coverage Δ
...ipt/tests/function_libs/torch_lib/ops_test_data.py 95.52% <ø> (ø)

... and 1 file with indirect coverage changes

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Test Results

         18 files  ±    0         18 suites  ±0   1h 1m 31s ⏱️ - 3m 48s
    9 748 tests ±    0    7 239 ✔️ ±  0      2 509 💤 ±    0  0 ❌ ±0 
135 549 runs  +246  29 604 ✔️ +36  105 945 💤 +210  0 ❌ ±0 

Results for commit c477cc6. ± Comparison against base commit 2f39b94.

@justinchuby justinchuby merged commit 8e58016 into main Aug 5, 2023
@justinchuby justinchuby deleted the justinchu/remove-skips-1 branch August 5, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

Assignees
No one assigned
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[torchlib] Fix scaled_dot_product_attention
2 participants
@justinchuby @titaiwangms