Repo: Update to the 2024 edition #1425
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalis-msft
force-pushed
the
edition-2024
branch
from
917fb32 to
27ad5d3
Compare
smalis-msft
force-pushed
the
edition-2024
branch
from
27ad5d3 to
33224bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have spot checked about 50 of the 300-ish hits the remaining lints have, as well as manually searching for known potentially problematic patterns, and am relatively certain that the drop order changes will not affect us. Thus the last blocker is removed, and we can update. This naturally introduced a few new minor lint issues, so those are fixed here.
Closes #288