vmgstool: make query-size output easier to parse #2424
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the programmatic usability of the query-size command by separating human-readable debug output from machine-readable data. The informational log message is moved to stderr while the size value itself is printed to stdout, making it straightforward to parse the command output in scripts and automation.
- Moved descriptive message to stderr for debugging purposes
- Added clean size-only output to stdout for easy parsing
smalis-msft
reviewed
Nov 17, 2025
| file_id.0, file_id, file_size | ||
| ); | ||
|
|
||
| println!("{file_size}"); |
Contributor
There was a problem hiding this comment.
If we're expecting people to take a dependency on this behavior we should have comments saying what's stable and what's not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak the output of query-size such that only the size itself is printed to stdout to make it easier for consumers of VmgsTool to parse programmatically. The log intended to be human readable has been shifted to stderr for debugging purposes.