Skip to content

Fix Terraform diagnostic parsing and Docusaurus links breaking main CI #1625

Description

@jkim323

Two failures observed at commit 48da998884ff5441c08d380dbe6b5506f83a572f require fixes: Terraform validation crashes while reading optional diagnostic fields, and documentation build verification fails on repository-only relative Markdown links. Preserve genuine validation failures and strict documentation link checks.

Terraform validation failure

scripts/linting/Invoke-TerraformValidation.ps1 dereferences $diag.range.filename and $diag.range.start.line under strict mode, but Terraform may omit range or return null. The job reports: The property 'range' cannot be found on this object.

The wrapper also discards terraform init output and ignores its exit code. The parser crash prevents the JSON results artifact from being written, masking the original Terraform diagnostic. That underlying diagnostic remains unknown.

Documentation build failure

All 20 Docusaurus unit tests passed, but Build verification failed because newly added relative Markdown links point outside the site's docs/ content root. The targets exist in Git but are not published Docusaurus pages.

Affected pages:

  • docs/contributing/README.md: commit-message instructions and root CONTRIBUTING testing requirements.
  • docs/contributing/ROADMAP.md: root CHANGELOG.
  • docs/contributing/deployment-validation.md: root CONTRIBUTING testing requirements.
  • docs/reference/workflow-templates-azureml.md: repository AzureML workflow index.

Use absolute GitHub URLs for these five repository-only links, retaining valid fragments.

Acceptance Criteria

  • Missing or null diagnostic locations and optional detail do not crash Terraform reporting; located diagnostics retain filename and line.
  • Initialization failures preserve their output, skip validation for that directory, and still produce a report covering other directories.
  • Non-JSON validation failures are reported without losing the results artifact.
  • Genuine Terraform failures remain nonzero; existing annotation summaries and report schema remain compatible.
  • All five repository-only links are corrected and Docusaurus tests/build pass without weakening broken-link checks.
  • Focused PowerShell tests and lint pass, fixes are merged, and fresh CI confirms the affected jobs; any newly exposed Terraform error is investigated.

Local Validation

A local repair was implemented and validated during investigation:

  • 31 existing Pester tests passed.
  • 9 in-memory wrapper edge-case checks passed.
  • 20 Docusaurus tests and production build passed under Node 24.14.1.
  • Focused PowerShell analysis, Markdown lint, spelling, and diff whitespace checks passed.

Remote CI has not been verified after the repair. Three non-fatal documentation anchor warnings remain outside this fix. The separate uv download HTTP 504 failure is not included in this issue.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions